fix(harvester): merge duplicate contributors#869
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
TahaKhan998
force-pushed
the
fix/issue-861-merge-duplicate-contributors
branch
2 times, most recently
from
July 21, 2026 14:25
645fde7 to
f5937bc
Compare
TahaKhan998
force-pushed
the
fix/issue-861-merge-duplicate-contributors
branch
from
July 21, 2026 14:41
f5937bc to
e516496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861
The harvester was failing when a CDS record contained multiple contributor entries matching the same incoming INSPIRE contributor. Since it could not decide which entry to update, it raised a
Multiple creators match incomingconflict.This PR merges the matching CDS contributor entries before applying the incoming INSPIRE data. Metadata, identifiers, and affiliations from the existing entries are preserved while exact duplicates are removed.
It also fixes the
duplicated affiliationserrors that appeared when the same records were harvested again. The affiliation merge previously checked duplicate names but always appended ID-based affiliations, so repeated runs could add the same vocabulary ID more than once. Affiliations are now deduplicated by both ID and name across the stored and incoming data, including duplicates already present in the CDS record.Finally, strict update conflicts are logged only by the writer instead of both the update engine and writer, so the same error no longer appears twice in the harvester report.